start-jsk / jsk_apc

Other

36 stars 35 forks source link

Fix :recognize-object to return t or nil #2661

Closed pazeshun closed 6 years ago

pazeshun commented 6 years ago

2648 makes `is-recognized` time stamp or nil, but `:recognize-object` should return t or nil for state machine.

pazeshun commented 6 years ago

Can we add (not is-recognized) in pick-main or stow-main.l? Some of my programs need is-recognized to be timestamp.

I created #2662 to fulfil your request. However, I'm against your idea because all methods in pick-interface or stow-interface called from pick-main or stow-main return t or nil.

2662 violates that regularity.

wkentaro commented 6 years ago

I'm not sure why we need to set that regularity. Do you have any idea? @knorth55 Maybe we can add tests for that.

pazeshun commented 6 years ago

Oops, my misunderstanding... https://github.com/start-jsk/jsk_apc/blob/master/jsk_arc2017_baxter/euslisp/pick-main.l#L81-L82 Now I allow #2662

pazeshun commented 6 years ago

Closed https://github.com/start-jsk/jsk_apc/pull/2662#issuecomment-423604708

start-jsk / jsk_apc

Fix :recognize-object to return t or nil #2661

2648 makes is-recognized time stamp or nil, but :recognize-object should return t or nil for state machine.

2662 violates that regularity.

2648 makes `is-recognized` time stamp or nil, but `:recognize-object` should return t or nil for state machine.