search

start-jsk / jsk_apc

Other
36 stars 35 forks source link

Stop using VOCdevkit tar file to test extractall function #2703

Closed wkentaro closed 5 years ago

wkentaro commented 5 years ago

Close https://github.com/start-jsk/jsk_apc/pull/2702

knorth55 commented 5 years ago

LGTM BTW, are you using VOC data in occlsegm or grasp fusion? if so, we should switch to google drive link to download it.

wkentaro commented 5 years ago

This is devkit, not dataset, so should be fine, right?

I'm not 100% sure, but probably not (grep says it's only used in tests):

Screen Shot 2019-11-04 at 01 08 39
wkentaro commented 5 years ago

I found that 5MB.zip is not actually the zip file, so updated.

knorth55 commented 5 years ago

LGTM. I prefer using hub released tar.gz.