add github actions - Githubissues

start-jsk / jsk_apc

Other

36 stars 35 forks source link

add github actions #2745

Closed knorth55 closed 3 years ago

knorth55 commented 3 years ago

add github actions for indigo, kinetic and melodic.

exclude instance_occlsegm and grasp_fusion test because of gdrive download maximum trials

knorth55 commented 3 years ago

all test passed!

knorth55 commented 3 years ago

@pazeshun I add github actions for faster CI than travis CI. we do not run several tests in github actions, and we run whole tests in travis CI. what do you think?

Another issue is that we want to support noetic for the near future. I started doing the integration in #2746, but we have to wait to upstream repositories.

pazeshun commented 3 years ago

@pazeshun I add github actions for faster CI than travis CI. we do not run several tests in github actions, and we run whole tests in travis CI. what do you think?

I think it's OK. Thank you very much for heavy installation!!!

* exclude `instance_occlsegm` and `grasp_fusion` test because of gdrive download maximum trials

Just out of curiosity, is this actually avoidable by using cache? https://dev.to/github/caching-dependencies-to-speed-up-workflows-in-github-actions-3efl Anyway, we currently have no time to use this, and travis targeting master branch is enough, I think.

knorth55 commented 3 years ago

@pazeshun thanks.

Just out of curiosity, is this actually avoidable by using cache? https://dev.to/github/caching-dependencies-to-speed-up-workflows-in-github-actions-3efl Anyway, we currently have no time to use this, and travis targeting master branch is enough, I think.

I will take a look later.

knorth55 commented 3 years ago

@pazeshun I fixed the typos before your suggestions.

pazeshun commented 3 years ago

@pazeshun I fixed the typos before your suggestions.

Oops, I overlooked this. Sorry...

knorth55 commented 3 years ago

github action cache does not work properly because of permission error.

https://github.com/ros-tooling/setup-ros-docker/issues/7 https://github.com/actions/cache/issues/404

knorth55 commented 3 years ago

I comment out github actions cache