search

start-jsk / jsk_mbzirc

4 stars 15 forks source link

move uav_teleop_keyboard to jsk_mbzirc_tasks, no launch file in jsK_mbzirc_common use them #52

Closed k-okada closed 8 years ago

tongtybj commented 8 years ago

merge?

k-okada commented 8 years ago

merge if you and @cretaceous-creature is ok with this

cretaceous-creature commented 8 years ago

I am fine with okada sensei's idea of using teleop_twist_keyboard , but in fact I prefer to use the keyboard layout of uav_teleop_keyboard for both uav and ugv...
Better to leave this node in task for custom use than remove it....

k-okada commented 8 years ago

if so, you can send PR to switch keybindings in teleop_twist_keyboad, you can also check https://github.com/ros-teleop/teleop_tools

◉ Kei Okada

On Sun, Jan 24, 2016 at 2:45 PM, Chen notifications@github.com wrote:

I am fine with okada sensei's idea of using teleop_twist_keyboard , but in fact I prefer to use the keyboard layout of uav_teleop_keyboard for both uav and ugv...

Better to leave this node in task for custom use than remove it....

— Reply to this email directly or view it on GitHub https://github.com/tongtybj/mbzirc/pull/52#issuecomment-174258338.

cretaceous-creature commented 8 years ago

OK, okada sensei, Thank you very much.

2016-01-24 19:17 GMT+08:00 Kei Okada notifications@github.com:

if so, you can send PR to switch keybindings in teleop_twist_keyboad, you can also check https://github.com/ros-teleop/teleop_tools

◉ Kei Okada

On Sun, Jan 24, 2016 at 2:45 PM, Chen notifications@github.com wrote:

I am fine with okada sensei's idea of using teleop_twist_keyboard , but in fact I prefer to use the keyboard layout of uav_teleop_keyboard for both uav and ugv...

Better to leave this node in task for custom use than remove it....

— Reply to this email directly or view it on GitHub https://github.com/tongtybj/mbzirc/pull/52#issuecomment-174258338.

— Reply to this email directly or view it on GitHub https://github.com/tongtybj/mbzirc/pull/52#issuecomment-174284194.