start-jsk / jsk_mbzirc

4 stars 15 forks source link

add "sensor_pose_estimation based control" flag in launch file. #65

Closed tongtybj closed 8 years ago

tongtybj commented 8 years ago

Add the arg "use_ground_truth" in launch file. When the arg "use ground truth" is true, no pose estimation(egomotion) is processed, and the control is based on the ground truth value.

On the other hand, when the arg is false, the pose estimation begins to integrate sensors (c.f. imu, gps, baro(hieght)) to generate a combined 6-dof state(odmetry). The control is then based on the odometry from the pose estimation.

The gps and baro sensor model plugin is provide by either hector_quadcopter_gazebo_plugin or hector_gazebo_plugin which already contain the noise(based on Gussian). This issue is related to #63 and #64

tongtybj commented 8 years ago

also add ground hit check function which is mentioned in #62 . Right now I just check the relative height of drone based on the ground. But I think real contact detection is better. @k-okada how to detect the contact or collision between two models in gazebo?

k-okada commented 8 years ago

as far as I understand, this is "truck" plugin, so he does not understand where the drone is. to get ground truth, we'd use/update hector_quadcopter_gazebo_plugin or we can use p3d plugin ( http://gazebosim.org/tutorials?tut=ros_gzplugins#P3D(3DPositionInterfaceforGroundTruth) )

how to detect the contact or collision between two models in gazebo?

i think https://github.com/start-jsk/jsk_mbzirc/blob/master/jsk_mbzirc_common/src/mbzirc_gazebo_truck_plugin.cpp#L159 is good starting point

tongtybj commented 8 years ago

@k-okada Crushing after hitting ground is a special rule for task1. In task3, drones may always hit to ground to pick up the object. So, hardcoding in hector_quadcopter_gazebo_plugin may not be a good choice. Adding an additional plugin like "task1 plugin" is my suggestion. Actually, the "truck" plugin contains lot of rules about task1 beyond the truck movement. So I put code into the truck plugin. And in p3d plugin, should I use "bumper" plugin to realize the contact?

k-okada commented 8 years ago

in task3, the drone will not collide with ground, but boxes.

◉ Kei Okada

On Fri, Apr 15, 2016 at 1:40 AM, 趙 漠居 notifications@github.com wrote:

@k-okada https://github.com/k-okada Crushing after hitting ground is a special rule for task1. In task3, drones may always hit to ground to pick up the object. So, hardcoding in hector_quadcopter_gazebo_plugin may not be a good choice. Adding an additional plugin like "task1 plugin" is my suggestion. Actually, the "truck" plugin contains lot of rules about task1 beyond the truck movement. So I put code into the truck plugin. And in p3d plugin, should I use "bumper" plugin to realize the contact?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/start-jsk/jsk_mbzirc/pull/65#issuecomment-210040917

k-okada commented 8 years ago

by the why, this features is an optional, not mandatory , just to check if someone invent unrealistic strategies.

◉ Kei Okada

On Fri, Apr 15, 2016 at 7:20 PM, Kei Okada k-okada@jsk.t.u-tokyo.ac.jp wrote:

in task3, the drone will not collide with ground, but boxes.

◉ Kei Okada

On Fri, Apr 15, 2016 at 1:40 AM, 趙 漠居 notifications@github.com wrote:

@k-okada https://github.com/k-okada Crushing after hitting ground is a special rule for task1. In task3, drones may always hit to ground to pick up the object. So, hardcoding in hector_quadcopter_gazebo_plugin may not be a good choice. Adding an additional plugin like "task1 plugin" is my suggestion. Actually, the "truck" plugin contains lot of rules about task1 beyond the truck movement. So I put code into the truck plugin. And in p3d plugin, should I use "bumper" plugin to realize the contact?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/start-jsk/jsk_mbzirc/pull/65#issuecomment-210040917

tongtybj commented 8 years ago

Right now I also added the gimbal module for sensor in this branch. Please check the issue #66

furushchev commented 8 years ago

@tongtybj For keeping higher quality of your great contribution, you might be better to:

tongtybj commented 8 years ago

Separate into #82~#84. Closed this.