[jsk_mbzirc] enable roslint on testing

[furushchev]

@tongtybj あとはお願いします。。 もう少し詳しく・・・ このPRのテストは現時点で必ずfailします。 バクイさんの手元で

roscd jsk_mbzirc_common
cd ..
git remote add furushchev https://github.com/furushchev/jsk_mbzirc
git fetch furushchev
git checkout add-roslint

をするとこのPRのブランチになります。 このディレクトリで

sudo apt-get install ros-indigo-roslint # 必要な場合
rosrun roslint cpplint $(find . -iname "*.h")
rosrun roslint cpplint $(find . -iname "*.cpp")
rosrun roslint pep8 $(find . -iname "*.py")

とすると要改善点が列挙されるので、直して、僕のブランチにPRしてください。

僕のブランチへのPRの作り方は

git push tongtybj add-roslint

して、githubの画面を見るとCreate Pullrequestがあるはずです。 Compare Changesというタイトルの画面になるので、Base forkをfurushchev/jsk_mbzirc add-roslintにしてPRを作成すればOKです。

CMakeLists.txtはcatkin lintをするか@k-okada lintをするというのでいいのではないでしょうか。

[tongtybj]

travic always stops becuase: The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over). The job has been terminated

[k-okada]

https://github.com/jsk-ros-pkg/jsk_travis/blob/master/travis.sh#L188 may help

◉ Kei Okada

On Sat, Apr 23, 2016 at 12:21 AM, 趙 漠居 notifications@github.com wrote:

travic always stops becuase:

the test suite is raising the same exception over and over).

The job has been terminated```

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/start-jsk/jsk_mbzirc/pull/68#issuecomment-213470816

[furushchev]

maybe there are other problems which does not pass tests. Please don't merge until passes existing tests.

[furushchev]

Finally, travis passed with tests. This PR includes independent feature to be updated, so I will now split them to another PR.

• [jsk_mbzirc] fix for travis test https://github.com/start-jsk/jsk_mbzirc/pull/70

[furushchev]

Please merge after #70

[furushchev]

rebased origin/master

[furushchev]

rebased origin/master #72

[furushchev]

now travis passed and verified that roslint is enabled. @k-okada Please merge if there is no problem.

The command "xvfb-run -a --server-args="-screen 0 800x600x24" catkin build --catkin-make-args run_tests -- -p1 -j1 --limit-status-rate 0.017 --summarize $REPOSITORY_NAME --no-deps" exited with 0.
$ catkin_test_results --all --verbose build
jsk_mbzirc_common/test_results/jsk_mbzirc_common/roslaunch-check_launch_mbzirc_arena.launch.xml: 1 tests
jsk_mbzirc_common/test_results/jsk_mbzirc_common/roslaunch-check_launch_mbzirc_arena_1.launch.xml: 1 tests
jsk_mbzirc_common/test_results/jsk_mbzirc_common/roslaunch-check_launch_mbzirc_arena_2.launch.xml: 1 tests
jsk_mbzirc_common/test_results/jsk_mbzirc_common/roslaunch-check_launch_mbzirc_arena_3.launch.xml: 1 tests
jsk_mbzirc_common/test_results/jsk_mbzirc_common/roslint-jsk_mbzirc_common.xml: 1 tests
jsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/roslaunch-check_launch_jsk_mbzirc_task_1.launch.xml: 1 tests
jsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/roslaunch-check_launch_jsk_mbzirc_task_2.launch.xml: 1 tests
jsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/roslint-jsk_mbzirc_tasks.xml: 1 tests
jsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/rostest-test_jsk_mbzirc_task_1.xml: 2 tests
jsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/rostest-test_jsk_mbzirc_task_2.xml: 2 tests
jsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/rosunit-completed_test.xml: 1 tests
jsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/rosunit-remaining_time_test.xml: 1 tests
Summary: 14 tests, 0 errors, 0 failures