search

start-jsk / openhrp3

This package does not only wrap OpenHRP3 but actually provides the built artifact from the code from its mainstream repository. Being ROS-agnostic by itself, you can also use this via ROS together with the packages in rtmros_common that bridge between two framework.
1 stars 5 forks source link

Update ROS release artifact from 3.1.5-2 #22

Closed 130s closed 10 years ago

130s commented 10 years ago

To apply this commit to ROS .deb.

Just wanted to raise an attention: To release .deb by only incrementing build version (MAJOR.MINOR.PATCH-BUILD) is NOT allowed in ROS. So this must not happen often.

I share how to do this JUST IN CASE it's needed in the future by someone else.

  1. Update release tag on your upstream repository. Do not use automation tools from ROS (eg. catkin_prepare_release, catkin_generate_changelogs). If the same tag already exists, you might want to remove it first and then push again with your new data that you're releasing this time.
  2. Run bloom-release. Process normally, push the artifact that's built by bloom to your release repository. Open a pull request (bloom will ask you to do so) to modify rosdistro with the new build version.
  3. Go to the web page of the pull request you just opened, and add explanation why you have to increment build version. Since rosdistro maintainers are very careful with every detail, you have to give sufficient reasoning.
130s commented 10 years ago

Done in rosdistro.

k-okada commented 10 years ago

sorry, we need to check this patch --> https://github.com/start-jsk/openhrp3/pull/23

130s commented 10 years ago

Pre-release testing from "source" (not from release repo, which means this should be presumable grabbing the latest source) failed, at downstream build test of hrpsys.

http://jenkins.ros.org/job/prerelease-hydro-openhrp3/ARCH_PARAM=amd64,UBUNTU_PARAM=precise,label=prerelease/2/consoleFull

Check if /tmp/test_repositories/build_repository/devel/share/openhrp3/share/OpenHRP-3.1/idl/OpenHRP/ClockGenerator.idl exists
CMake Error at idl/CMakeLists.txt:120 (message):
  ERROR:
  /tmp/test_repositories/build_repository/devel/share/openhrp3/share/OpenHRP-3.1/idl/OpenHRP/ClockGenerator.idl
  is not present

-- Configuring incomplete, errors occurred!
make: *** [installed] Error 1
CMake Error at hrpsys/catkin.cmake:25 (message):
  Compile hrpsys failed
Call Stack (most recent call first):
  hrpsys/CMakeLists.txt:2 (include)

But looks like ClockGenerator.idl is installed.

-- Installing: /tmp/test_repositories/build_repository/devel/share/OpenHRP-3.1/idl/OpenHRP/ClockGenerator.idl

So at this point we could make a judgement call to re-release OpenHRP3 package (by incrementing build version again). @k-okada if you could confirm that there won't be update, I'll release this again. If there are still work ongoing I'll just wait.

k-okada commented 10 years ago

On my local environment, it seems ok

130s commented 10 years ago

Ok then I'll increment now

130s commented 10 years ago

Done. We'll see how this goes...

130s commented 10 years ago

Needs redone maybe because of https://github.com/start-jsk/openrtm_aist_core/issues/23

130s commented 10 years ago

Once openrtm_aist_core builds on Groovy, I'll re-release OpenHRP3 into Groovy, and Hydro.

130s commented 10 years ago

OpenHRP3 builds fine with the updated openrtm_aist_core 1.1.0-4.

Still, I assume OpenHRP3 needs to be re-released for this commit to be applied? @k-okada

130s commented 10 years ago

I just re-released OpenHRP3 3.1.5-5 into Groovy -- it was an old 3.1.5-3 and thus hrpsys didn't build on pre-release. Closing.