search

start-jsk / rtmros_gazebo

gazebo simulation for rtmros robots
8 stars 24 forks source link

fix .travis.rosinstal to use fkanehiro/hrpsys-base #248

Closed Naoki-Hiraoka closed 4 years ago

Naoki-Hiraoka commented 4 years ago

Currently rtmros_gazebo is tested with https://github.com/start-jsk/hrpsys, which is a deprecated repository.

.travis.rosinstal is fixed to use https://github.com/fkanehiro/hrpsys-base.

Naoki-Hiraoka commented 4 years ago

It takes too long time to test with USE_DEB=false USE_TRAVIS=true. We have to use USE_DEB=false USE_JENKINS=true instead.

I found a bug on using ' in BEFORE_SCRIPT on jenkins. https://github.com/jsk-ros-pkg/jsk_travis/issues/171#issuecomment-612586771 I had to avoid using ' in BEFORE_SCRIPT https://github.com/start-jsk/rtmros_gazebo/commit/9ca04fa0d6c1e562d582eedd240c4c980724d7bc

Naoki-Hiraoka commented 4 years ago

rtmros_gazebo and rtmros_tutorials depend on each other. It is problematic.

I changed only rtmros_tutorials to be dependent on rtmros_gazebo. https://github.com/start-jsk/rtmros_gazebo/pull/248/commits/78cbeb5839880bb7c627279d1aadfb6b72690fc6 https://github.com/Naoki-Hiraoka/rtmros_tutorials/commit/3c23bc4d29c948d9ebbf32c556edfa587dee93c3

Naoki-Hiraoka commented 4 years ago

This PR is included in https://github.com/start-jsk/rtmros_gazebo/pull/249