Closed 130s closed 6 years ago
英語はわからないんですが、
https://github.com/fkanehiro/hrpsys-base/blob/master/rtc/ImpedanceController/ImpedanceController.cpp#L790 std::cerr << "[" << m_profile.instance_name << "] Could not found impedance controller param [" << iname << "]" << std::endl; みたいな言い方がいいんじゃないでしょうか.
-- ◉ Kei Okada
2017-05-12 8:10 GMT+09:00 Isaac I.Y. Saito notifications@github.com:
@130s https://github.com/130s requested your review on: start-jsk/rtmros_hironx#502 https://github.com/start-jsk/rtmros_hironx/pull/502 [ros_bridge.py][startImpedance_315_3] More precise error message..
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/start-jsk/rtmros_hironx/pull/502#event-1079154582, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3PaJ5ae88i-XJbAen__LGO1cne_Iks5r45V4gaJpZM4NYgsx .
Commit updated as suggested.
However, I'm still afraid that the fact "impedance parameter wasn't found" does not tell the users what to do, and I have no answer to that.
I'll leave this open until I think of better message.
When run by itself,
getImpedanceControllerParam
command at least finishes, so it's not failing. The error message is a bit misleading about what happened internally instartImpedance_315_3
method.