start-jsk / rtmros_hironx

hironx controller and applications using rtmros packages
http://wiki.ros.org/rtmros_hironx
10 stars 27 forks source link

compiled on ROS Kinetic #506

Closed yswhynot closed 7 years ago

yswhynot commented 7 years ago

Minor change to get compiled on ROS Kinetic on Ubuntu 16.04

130s commented 7 years ago

Thanks for the PR. AFAIK, one of the dependencies of this package, rtmros_common, isn't available on Kinetic yet so I don't think this package does not work on Kinetic at the moment, even though you may be able to build.

Thus at this moment I'll leave this unmerged.

Have you also confirmed that it works on Kinetic?

yswhynot commented 7 years ago

I confirm this can be built in ROS Kinetic on Ubuntu 16.04 but the PR2 mechanics package is not compatible with Kinetic (https://github.com/PR2/pr2_mechanism/issues/330) so I cannot test whether this can work or not :(

k-okada commented 7 years ago

from 2.0.0 of this package, we can compile both indigo and kinetic.