[hrpsys_ros_bridge_tutorials] Ignore generated models

[wkentaro]

It is annoying if there are too many untracking files generated by build at running git status.

[k-okada]

do you think we can write with some rules?, like '*.dae', instaed of writing all files in .gitigure

[wkentaro]

*.dae seems fine, but there are already *.urdf files, so it demands additional rules. The current declaration is based on a blacklist rule, and if we use whitelist rule, the lines of .gitignore will be short. But user will need to declare .urdf file in .gitignore to add a new file to commit every times. Below is the white list example.

*.dae
*.urdf

# white list
!HRP2JSKNTS_body_customHEAD.urdf
!HRP2JSKNTS_customHEAD.urdf

I thought this is not friendly for users who are not familiar with git, and they will say "git add not work! Why I can't stage it to commit?".

What do you think?

[k-okada]

It may surprising for you , but someone do not care about .gitignore, or even they do not like that. https://github.com/jsk-ros-pkg/trans_system/pull/49#issuecomment-74263087, (and sadly two people who liked .gitignore not longer using this package and people who like this have to keep maintain this, also we can find another one take care about .gitignore https://github.com/jsk-ros-pkg/trans_system/commits/master/projects/trans_vm/.gitignore

this thread is very insightful..)

so question is; are you ok with add new blacklist everytime someone add a new robot? or do you want to answer git add question? and since adding new urdf is not welcomed, basically we should convert from wrl (at least I believe so) so in that case you can answer "adding new urdf is not a good thing, try to convince @k-okada about why you need this)'

So if I ware you, I'll chose white list, but if you are ok with blacklist, I'll merge this (but maybe most of user do not like this ....)

◉ Kei Okada

On Sat, Aug 27, 2016 at 4:15 AM, Kentaro Wada notifications@github.com wrote:

.dae seems fine, but there is already .urdf files, so it demands additional rules. The current declaration is based on a blacklist rule, and if we use whitelist rule, the lines of .gitignore will be short. But user will need to declare .urdf file in .gitignore to add a new file to commit every times. Below is the white list example.

.dae .urdf

white list

!HRP2JSKNTS_body_customHEAD.urdf !HRP2JSKNTS_customHEAD.urdf

I thought this is not friendly for users who are not familiar with git, and they will say "git add not work! Why I can't stage it to commit?".

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/start-jsk/rtmros_tutorials/pull/487#issuecomment-242826355, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3KW3krkWq-Bny6HFBaiMnBcuyY9hks5qjztUgaJpZM4Js440 .

[wkentaro]

Thanks for the comments. I think the whilte listing is better. Fixed.