search

start-jsk / rtmros_tutorials

Tutorials for rtmros packages
6 stars 61 forks source link

Fix indigo test with .travis.rosinstall & add kinetic test #566

Closed pazeshun closed 4 years ago

pazeshun commented 4 years ago
pazeshun commented 4 years ago

Building hrpsys_gazebo_tutorials failed on kinetic, because hrpsys_gazebo_general is not released on kinetic:

Errors << hrpsys_gazebo_tutorials:cmake /workspace/ros/ws_rtmros_tutorials/logs/hrpsys_gazebo_tutorials/build.cmake.000.log
CMake Warning at /opt/ros/kinetic/share/catkin/cmake/catkinConfig.cmake:76 (find_package):

  Could not find a package configuration file provided by

  "hrpsys_gazebo_general" with any of the following names:

    hrpsys_gazebo_generalConfig.cmake

    hrpsys_gazebo_general-config.cmake

  Add the installation prefix of "hrpsys_gazebo_general" to CMAKE_PREFIX_PATH

  or set "hrpsys_gazebo_general_DIR" to a directory containing one of the

  above files.  If "hrpsys_gazebo_general" provides a separate development

  package or SDK, be sure it has been installed.

Call Stack (most recent call first):

  CMakeLists.txt:4 (find_package)

CMake Error at /opt/ros/kinetic/share/catkin/cmake/catkinConfig.cmake:83 (find_package):

  Could not find a package configuration file provided by

  "hrpsys_gazebo_general" with any of the following names:

    hrpsys_gazebo_generalConfig.cmake

    hrpsys_gazebo_general-config.cmake

  Add the installation prefix of "hrpsys_gazebo_general" to CMAKE_PREFIX_PATH

  or set "hrpsys_gazebo_general_DIR" to a directory containing one of the

  above files.  If "hrpsys_gazebo_general" provides a separate development

  package or SDK, be sure it has been installed.

Call Stack (most recent call first):

  CMakeLists.txt:4 (find_package)

cd /workspace/ros/ws_rtmros_tutorials/build/hrpsys_gazebo_tutorials; catkin build --get-env hrpsys_gazebo_tutorials | catkin env -si  /usr/bin/cmake /workspace/ros/ws_rtmros_tutorials/src/rtmros_tutorials/hrpsys_gazebo_tutorials --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/workspace/ros/ws_rtmros_tutorials/devel/.private/hrpsys_gazebo_tutorials -DCMAKE_INSTALL_PREFIX=/workspace/ros/ws_rtmros_tutorials/install; cd -

...............................................................................
Failed << hrpsys_gazebo_tutorials:cmake               [ Exited with code 1 ]

(from https://travis-ci.org/start-jsk/rtmros_tutorials/jobs/628036347)

pazeshun commented 4 years ago

I found there are two test_samplerobot_hrpsys: https://github.com/start-jsk/rtmros_tutorials/blob/0.1.6/hrpsys_ros_bridge_tutorials/test/test_hrpsys_pa10.launch#L12 https://github.com/start-jsk/rtmros_tutorials/blob/0.1.6/hrpsys_ros_bridge_tutorials/test/test_hrpsys_samplerobot.launch#L18 If there are two ros tests which have the same name, the result of the firstly executed one is overwritten by the secondly executed one. On indigo test, the result of the former one (test of PA10) is overwritten. So I fixed this test name to test_pa10_hrpsys at b1abcf7.

Then I found test_pa10_hrpsys always fails (see https://travis-ci.org/start-jsk/rtmros_tutorials/builds/628279441). Previously, we couldn't find that because the test result was overwritten. I found the failure cause is lacking of start_omninames.sh in test_hrpsys_pa10.launch, and fixed that at 0880f70. (In contrast, test_hrpsys_samplerobot.launch already has start_omninames.sh, so its tests pass: https://github.com/start-jsk/rtmros_tutorials/blob/0.1.6/hrpsys_ros_bridge_tutorials/test/test_hrpsys_samplerobot.launch#L8-L9)

pazeshun commented 4 years ago

@YoheiKakiuchi Could you review & merge this?

pazeshun commented 4 years ago

@YoheiKakiuchi Kindly ping.

pazeshun commented 4 years ago

@k-okada @YoheiKakiuchi Could you merge this?

pazeshun commented 4 years ago

@k-okada @YoheiKakiuchi Kindly ping

pazeshun commented 4 years ago

@k-okada Kindly ping