search

start-react / sb-admin-react

Starter theme for React JS Dashboard Apps
http://sb-admin-react.geekydev.com:3009/
Other
836 stars 274 forks source link

Module not found error in all the tests. #12

Open debojitkakoti opened 8 years ago

debojitkakoti commented 8 years ago

ERROR in ./test/routers/test_logged_out.jsx Module not found: Error: Cannot resolve 'file' or 'directory' ../../src/routers/logged_out in /home/workspace/sb-admin-react/test/routers @ ./test/routers/test_logged_out.jsx 15:28-67 Steps to reproduce: npm test

The import path in all the test cases is pointing to wrong directory !

sanketsahu commented 8 years ago

Thanks for the report. We are not free at the moment. Can you fix that and send pull request?

debojitkakoti commented 8 years ago

I will try to fix it. Thanks .

ssteinerx commented 8 years ago

None of the included files that are supposed to be in ../../src/common exist and it's unclear what's supposed to be in them. I looked back through the history and it doesn't seem that those files ever existed or that the test ever actually ran. NOTE: this is based on what's in the repository, I'm sure those files exist on someone's development machine, but they never made it into this repo.

ssteinerx commented 8 years ago

@sarika01 Do you have this files? I'm working on a fork and would love to start with some working tests, but the required files didn't get checked into this repo though I assume they existed on someone's development machine at some point.

sarika01 commented 8 years ago

@ssteinerx , those files were long back changed and renamed to the current structure. After that I haven't had the opportunity to write and update the test cases. But, just in case if it's helpful to you, I am attaching the files. extra files.zip

ssteinerx commented 8 years ago

@sarika01 Thanks! I'll work them in and see if I can get them working with the current build. If they're too out-of-date, I'll probably just start over with new, comprehensive set of tests, possibly even using a different set of tools.

If you're interested, please see my fork.

I've updated all of the dependencies other than Babel (which requires a major restructuring of the config file), but have no unit tests at the moment to prove it's all right.

So far, by rearranging devDependencies vs dependencies, I've reduced reduced build/ contents from 3.9M in the original v0.3.0 to ~1.9M in my 0.4.1 fork.

If you're interested, you could cherry-pick my changes back into your repository as a base, and I could rebase to that as a starting point, then pull my changes back in in a series of small, atomic pull requests.

Otherwise, if you'd rather not continue to maintain this, I'd be happy to take over development. If so, you could just redirect to my fork, and we can figure out how to get this published to NPM. Obviously, I'd leave all original attribution to you, and link to your company site etc. if you'd like and will get your approval before publishing.

Please let me know as, once I have a solid set of tests in place, this will be moving pretty quickly as I'm integrating it into a paid client project and so will have quite a bit of time to work on it.

Thanks,

Steve Steiner aka/ssteinerX

sarika01 commented 8 years ago

Hi @ssteinerx, it's really nice to see your active interest in this repo. We are going to maintain this repo in the long-term. Your changes and updated libraries are a great contribution and I would be happy to merge them here. We would also be happy to get the NPM module published and your support for this would always be appreciated! regards, Sarika