Fix negative margins causing horizontal-scrollbars

startae / hagrid

:straight_ruler: Hagrid is a mixin library for responsive websites and web applications.

https://hagrid.netlify.com/

MIT License

30 stars 3 forks source link

Fix negative margins causing horizontal-scrollbars #29

Closed fspoettel closed 9 years ago

fspoettel commented 9 years ago

Close #28
Remove margin-right & padding-right for all grids
Removes horizontal scrollbars on body
Confirmation needed: Does the grid render correctly in all cases? This was one of the things hagrid inherited from csswizardry-grids
Confirmation needed: Does the grid render without bars when the browser is set to rtl?
Tests cleared
[x] Chrome OSX
[x] Safari OSX
[x] Firefox OSX
[x] Android 4.0-4.4
[x] IE9, IE11, Edge 20
[x] iOS 9

fspoettel commented 9 years ago

@renatocarvalho Pretty confident this fixes the issue, not sure why csswizrdry-grids set the negative right-margin in the first place. Bootstrap seems to have the same problem, so maybe I'm missing something, but the tests work just fine.

renatocarvalho commented 9 years ago

@felics I'll test over here too and get back to you.

renatocarvalho commented 9 years ago

Hey @felics, I tested here on the main browsers on Mac (Chrome, Safari and Firefox), Safari for iOS, IE 11 and IE10 and everything looks fine. I would say we're good to go.

startae / hagrid

Fix negative margins causing horizontal-scrollbars #29

Tests cleared