startae / hagrid

:straight_ruler: Hagrid is a mixin library for responsive websites and web applications.
https://hagrid.netlify.com/
MIT License
30 stars 3 forks source link

Remove fallback #41

Closed fspoettel closed 8 years ago

fspoettel commented 8 years ago

Implementing #38

fspoettel commented 8 years ago

cc @renatocarvalho

renatocarvalho commented 8 years ago

Hey @felics Sorry for the delay. Here's what I have done:

I'm attaching the screenshots generated on Browserstack.

Windows 8, IE 10

win8_ie_10 0

Windows 8, IE 11

win8 1_ie_11 0

fspoettel commented 8 years ago

thanks for the report! A quick test showed that this bug in IE10-11 seems to cause this issue, as the new PR uses flex-basis for width-calculations. I think I have to revert it to using width and adjust the auto-grid. IE at it again

woohoo

renatocarvalho commented 8 years ago

haha, that image! Sad, but true. IE always blocking our way.

fspoettel commented 8 years ago

@renatocarvalho This should fix it - I tested it against a IE10 & IE11 VM and didn't see anything unusual.

renatocarvalho commented 8 years ago

I'm going to test here again too.

renatocarvalho commented 8 years ago

@felics Did all the tests here and it looks good! Liked the new colors for the grid tests. :shipit:

fspoettel commented 8 years ago

@renatocarvalho i'll push a last version of the v2 grid today (mainly cleaning up the code with stylelint) and remove the flexibility stuff from v3, as you might as well use v2 in the case of needing legacy support. After that, the only thing left to do before merging is adding a note about installing v2.x via npm/bower

renatocarvalho commented 8 years ago

@felics Sounds good :+1: