search

starteam / starcellbio_html

2 stars 7 forks source link

Create new assignment based on another #760

Closed annagav closed 6 years ago

annagav commented 7 years ago

What are the relevant tickets?

Related to #749

What's this PR do?

Allows the user to create a new assignment based on an existing one. Copies only experimental setup of the original assignment.

Where should the reviewer start?

How should this be manually tested?

Try creating an assignment. In 'assignment setup' choose the base assignment. Click 'next and continue' and check for experimental setup to be filled out just like in the original assignment.

Any background context you want to provide?

Screenshots (if appropriate)

What GIF best describes this PR or how it makes you feel?

pdpinch commented 6 years ago

@ald32 @laleman would jmclaus or idegtiarov be able to review this for Anna?

Or should we just close it?

jmclaus commented 6 years ago

@pdpinch @annagav @idegtiarov @laleman I tested the branch locally, it works like a charm and clones properly an assignment. I then merged the branch onto latest develop, again locally. It works but some fields seem to loose their value in the clone. In any case, considering that @idegtiarov is about to merge a PR and I too (2 PRs, another one is coming shortly), I'd recommend we postpone this until the above is done.