search

starteam / starcellbio_html

2 stars 7 forks source link

Fix tests #774

Closed jmclaus closed 7 years ago

jmclaus commented 7 years ago

This PR fixes 404 error when fetching 'soyutils.js during preview template load.

jmclaus commented 7 years ago

@annagav Installing npm_modules into html_app was a very bad idea (see PR). None of the numerous files that ended up populating npm_modules were needed except soyutils.js. It would slow down collectstatic and even choke the Travis build on certain occasions thus resulting in test failures. And it would also break the production build script as clean-css and uglify-js were not found at their past location.

This PR is now totally different. npm_modules is left outside of html_app and only soyutils.js is copied to html_app/js after npm install in both ansible-dev.yml and .travis.yml. And changes to the 2 templates no longer needed.

annagav commented 7 years ago

Works fine! 👍