Improve histograms - Githubissues

starteam / starcellbio_html

2 stars 7 forks source link

Improve histograms #778

Closed jmclaus closed 6 years ago

jmclaus commented 6 years ago

Add upper value for y-axis and implement log scale.
Remove x-axis ticks field. Ticks for both axis will be automatically generated.
Remove former preview canvases. Use square canvases to match student view.
Use polyline with draggable points to set up a guide for the noisy curve whose variation is determined by a slider
Use 'pointer' cursor for histogram tabs.

jmclaus commented 6 years ago

@annagav @idegtiarov I rebased the branch on develop and checked out that it didn't break anything with @idegtiarov recent merge.

annagav commented 6 years ago

Works great! The only thing the button doesn't fit the dialog: screen shot 2017-11-21 at 2 47 03 pm

jmclaus commented 6 years ago

@annagav Thanks. I fixed the button positioning and also decreased a bit the size of the div containing the histogram library so that only exactly 2 rows appear. I have scrollbars on both latest Chromium and Firefox but I do not see any in your screenshot. Do you have any?

select-histogram-popup

annagav commented 6 years ago

@jmclaus On a Mac the scroll bars are only visible when you are scrolling. I don't think this is a problem. Looks good! 👍

jmclaus commented 6 years ago

@annagav OK, great, I am on Linux. Will merge this when I get final approval from @laleman.