search

starteam / starcellbio_html

2 stars 7 forks source link

Improve a11y #781

Closed jmclaus closed 6 years ago

jmclaus commented 6 years ago

This is a first pass at improving accessibility on the instructor side. Focus outlines were reinstated on most elements. Odd constructs like anchors containing buttons were removed in favor of simple buttons. Tabbing order was corrected for the navigation buttons. Trash icons can now be accessed via keyboard as well as labels associated to file input types.

jmclaus commented 6 years ago

@pdpinch I have no further changes to merge except the above. Once done, please feel free to do a release.

annagav commented 6 years ago

@jmclaus how should this be tested?

jmclaus commented 6 years ago

@annagav Just tab to various GUI elements on the instructor side, they'll show they have focus and react to keyboard events ie for buttons, ENTER/SPACE, dropdowns, UP/DOWN etc. FYI, this is work in progress and some elements may not be reached by TAB or SHIFT+TAB as for example the popup windows etc.

jmclaus commented 6 years ago

@pdpinch PR is merged and StarCellBio is ready for new release. @annagav thanks for your quick review.