search

starter-code / binge

A website to search for TV shows to binge
https://binge.netlify.app
MIT License
0 stars 0 forks source link

chore(github): add pre-commit hooks #26

Closed davidholyko closed 3 years ago

davidholyko commented 4 years ago

reference: https://github.com/typicode/husky

pre commit should

eslint fix
prettier fix
trybick commented 3 years ago

Hey, would you still want this done? If so, I can pick it up

davidholyko commented 3 years ago

Hey Tim! that would be good. You can pick it up. I removed the semantic commit lint requirement.

trybick commented 3 years ago

Ok cool! If you want semantic commit for later, this might work https://github.com/zeke/semantic-pull-requests

Btw do you mind adding the hacktoberfest topic to your repo? :) I believe it needs to be added here to count

Screen Shot 2020-10-07 at 9 48 21 AM

davidholyko commented 3 years ago

This repo is not really meant to be open to the public. I'll try to find a way to make it semi private

trybick commented 3 years ago

Gotcha. The rules are confusing now. Don't worry about the topic then. I believe you can just add the label "hacktoberfest-accepted" to the PR (even if topic is not added)

PRs count if:
Submitted during the month of October AND (
  The PR is labelled as hacktoberfest-accepted by a maintainer OR
  Submitted in a repo with the hacktoberfest topic AND (
    The PR is merged OR
    The PR has been approved
  )
)

https://hacktoberfest.digitalocean.com/hacktoberfest-update