search

starterleague / starter_generators

Gem containing generators useful in class
MIT License
15 stars 5 forks source link

Bootstrap 3 vanilla or themed by default? #13

Open raghubetina opened 11 years ago

raghubetina commented 11 years ago

http://getbootstrap.com/examples/theme/

My gut says themed. But the flat one is easier to customize. But for our beginners, customization is probably not a priority?

http://getbootstrap.com/getting-started/#download-cdn

JeffCohen commented 11 years ago

Yeah I wasn't sure either. Currently you have to pass "default" as the theme name to get the default (vanilla) look instead of a bootswatch. Maybe we add "theme" too? Other options: "plain" and "colorful".

raghubetina commented 11 years ago

Sounds good. Or "flat", "themed", plus all the swatch names?

raghubetina commented 11 years ago

Even better, perhaps, would be if "rails g starter:style" (with no arguments) would use the theme by default, and then "rails g starter:style flat" would use the vanilla version.

JeffCohen commented 11 years ago

Problem is generators are supposed to show help if no args are provided. Hence I had to add the silly "default" theme name.

On Wednesday, September 4, 2013, rbetina wrote:

Even better, perhaps, would be if "rails g starter:style" (with no arguments) would use the theme by default, and then "rails g starter:style flat" would use the vanilla version.

— Reply to this email directly or view it on GitHubhttps://github.com/starterleague/starter_generators/issues/13#issuecomment-23836770 .

raghubetina commented 11 years ago

Ah I get it. Then I'd go with "flat", "themed", "cerulean", etc.

raghubetina commented 11 years ago

Not to be a pain, but since the CDN links include the version number, wouldn't we have to update the gem each time Bootstrap changes anyway? In which case, wouldn't there be benefits to including the assets (at least for the flat and themed, if not the swatches) in the gem?

JeffCohen commented 11 years ago

There's also a bootswatch called Flatly, might get confused if we call the default bootstrap style Flat.

Gem has to be updated either way - new CDN links or new versions of the packaged assets. Easier to change a CDN string than replacing any hardcoded js and css.

raghubetina commented 11 years ago

That's true. "Plain"? Nah, maybe just "default". Naming so hard!

raghubetina commented 11 years ago

I've kind of forked this issue's discussion on to a different topic, but:

What about including the less-rails-bootstrap gem? That way it will be up to date, and easily customizable.

https://github.com/metaskills/less-rails-bootstrap