search

startersacademy / fullstack-project-01

Learning Management System
MIT License
0 stars 5 forks source link

Add homepage #29

Closed treyhunner closed 9 years ago

treyhunner commented 9 years ago

This replaced #28 which had @Rauld1's node_modules directory committed to it by accident.

I used some git magic to edit the problematic commit that added the node_modules directory. For reference, here's what I did:

rm -rf node_modules  # I had to delete my node_modules directory to checkout the homepage branch
git checkout homepage
git branch -m home-page-without-node_modules
git log --name-only  # showed me which commit had all the node_modules files
git rebase -i 8d17801bc1a5dde8c020ad6f3f937d9795a26467~1
# change pick to edit for 8d178 commit
git rm -r node_modules/  # once rebase stops on the 8d178 commit for us
git rebase --continue
git push -u origin HEAD  # push new branch
# make pull request

This pull request should have a more manageable diff that can be reviewed now.

treyhunner commented 9 years ago

I noticed that these changes use a local copy of Bootstrap whereas some of the other pull requests use a CDN version. Once these changes are merged, I think you'll all want to decide on using either a local version or a CDN version and standardize.

jadedsurfer commented 9 years ago

For the integration test, you'll want to follow all of the header links to make sure they land on functioning pages. So basically, your code should click on the link, go back to the home page, click on the next link, etc.