startersacademy / fullstack-project-01

Learning Management System
MIT License
0 stars 5 forks source link

Student model #46

Closed Rauld1 closed 9 years ago

Rauld1 commented 9 years ago

Creates frisby test file. creates student.json file. Builds student.spec.js file.

jeffreytu commented 9 years ago
  "fullstack": {
    "name": "fullstack",
    "connector": "mongodb"
  }

Remove this above connection to the local database and put it in datasources.local.json. All of us will be using memory for our datasource. If you want to keep using mongo database locally, putting the above part in local.json will allow you to test with retained information.

goldlilys commented 9 years ago

@Rauld1 Like what jeff said, the gulpfile and neukinnis needs to get the latest from master. To make your life easier, instead of merging master to your branch and have to merge all conflicts, why not clone the new master and create a new branch where you add all the new changes you made, then open a new pull request and close this one? Since the neukinnis directory is gone, you're going to have a lot of merge conflicts to fix things and that might take longer than just moving your new files to a new branch. With starting from current master, most of the fixes for casper and the api that were done during the demo is there, but probably not on your version. Well you can try merging with master on this branch first, but if the result is too much errors, that's a suggestion.

goldlilys commented 9 years ago

All tests are passing but your api tests for students.spec.js seems to not be calling any of the functions? The create action is not inside a function and the postBadRecord is missing.

Other than that, if those missing stuff are fine, this can be merged.