search

startersclan / docker-sourceservers

Source / Goldsource dedicated server images built through use of steamcmd. 🐳
Apache License 2.0
47 stars 5 forks source link

Implement changes to accomodate new CircleCI UI #13

Closed joeltimothyoh closed 3 years ago

joeltimothyoh commented 4 years ago

A number of changes will have to be performed to accommodate CircleCI's move to its new UI:

  1. Update CircleCI build badge links
  2. Utilize Slack orb for Slack notifications if necessary

See: https://discuss.circleci.com/t/access-to-the-old-ui-will-be-shut-down-on-august-14th/36673

joeltimothyoh commented 3 years ago

Slack notifications for workflows still appear to be functioning despite the removal of the old slack integration options under project settings. Seems like they're pushing users to utilizing the Slack orb instead. I wouldn't say this is too urgent, since email notifications for workflows are still coming in as well.

See:

@leojonathanoh

leojonathanoh commented 3 years ago

yep, wait for the orbs stuff to mature first @joeltimothyoh

joeltimothyoh commented 3 years ago

yep, wait for the orbs stuff to mature first @joeltimothyoh

I think it already is pretty mature,. Based on the first link it's able to send a post notification for a workflow. it's just if the job fails the notification fails to send which makes less reliable than the old slack integration or email. An addition as elaborate as this shouldn't be a step backward for something basic offered by most alternative CI providers.

joeltimothyoh commented 3 years ago

The Circle CI app has been installed for the organization. Adding an orb may no longer be necessary for job notifications from CircleCI.

Now awaiting for the next game update to ascertain notifications from CircleCI checks work correctly.

leojonathanoh commented 3 years ago

@joeltimothyoh seems to be working. Only issue is the URLs on the notification has google analytics.

joeltimothyoh commented 3 years ago

@joeltimothyoh seems to be working. Only issue is the URLs on the notification has google analytics.

I don't see any notification. Link? @leojonathanoh

leojonathanoh commented 3 years ago

https://discord.com/channels/678934485512880128/682041430021242980/874794884576444426

joeltimothyoh commented 3 years ago

Ok. No notification on teams though. @leojonathanoh

joeltimothyoh commented 3 years ago

I tried enabling the project setting 'GitHub Status Updates' for the build job which completed much later after the update job:

image

However, according to https://circleci.com/docs/2.0/enable-checks/#to-disable-github-checks-for-a-project, enabling the setting disables checks. Yet, we received two notifications for the update job (https://discord.com/channels/678934485512880128/682041430021242980/874794884207374346, https://discord.com/channels/678934485512880128/682041430021242980/874794884576444426) but only 1 for the build job (https://discord.com/channels/678934485512880128/682041430021242980/874805522367397928). The build job's only notification however pertains to the workflow and so contradicts what's documented in https://circleci.com/docs/2.0/enable-checks/#to-disable-github-checks-for-a-project:

  • GitHub Checks are administered from the GitHub UI, and are reported in the GitHub UI per workflow.
  • GitHub status updates are the default way status updates from your builds are reported in the GitHub UI, and they are reported per job.

Either way, I've re-disabled the setting. Travis CI appears to send both notifications. The defaults are safe.

Since we're using discord for the community, with the CircleCI job notifications now appearing in the channel, this issue can be closed.

joeltimothyoh commented 3 years ago

Ok, perhaps the documentation is right in saying enabling the setting in https://github.com/startersclan/docker-sourceservers/issues/13#issuecomment-896401592 disables GitHub Checks for CircleCI since the equivalent of the 'CircleCI Checks checks on master' notification was missing for the update job. Yet, with the setting disabled (which is the default setting), both notifications come in. It's as though this setting but overrides to only enable GitHub status updates API calls for the project.

Keeping it simple.

Closing.

leojonathanoh commented 3 years ago

@joeltimothyoh all of these interactive configuration is why i dont like these externals CIs - you get a disintegrated ci experience and then have to manually configure so many things by hand. It's much easier to express a pipeline in a yaml.

joeltimothyoh commented 3 years ago

@joeltimothyoh all of these interactive configuration is why i dont like these externals CIs - you get a disintegrated ci experience and then have to manually configure so many things by hand. It's much easier to express a pipeline in a yaml.

There isn't a choice. Most CI providers don't offer a lot of disk space for building the games. @leojonathanoh