search

startnext / startnext-cypress

Startnext Cypress Image
MIT License
4 stars 2 forks source link

Puppeteer darf nicht als root laufen #2

Open gogowitsch opened 3 years ago

gogowitsch commented 3 years ago

Aktuell steht in der gitlab-ci.yml von cypress-hill noch apt install sudo.

Das gehört aus meiner Sicht ins Dockerfile, nicht in die gitlab-ci.yml. Ich hatte es nur als Proof of Concept da eingetragen.

MarauderXtreme commented 3 years ago

I would suggest, that we first check, if there is a way to fix this in the Gitlab CI without adding the sudo package but otherwise this call is correct and it should be added.

You have to keep in mind, that if the sudo package has a bug/security issue, this needs to be updated in the images too. So it could actually help to create an extra layer for the sudo package just to reduce the changing of layers.