stas-demydiuk / domoticz-plugins-manager

UI to manage python plugins in Domoticz
MIT License
14 stars 19 forks source link

Update done but in fact no update is done #21

Open darrepac opened 3 years ago

darrepac commented 3 years ago

Hello

I am just starting using your plugin manager that sounds great. I am willing to update Shelly_MQTT plugin that I have running on version 0.5.5 in my system On Shelly_MQTT repository the version is 0.5.9 and when I press update in plugin manager, and it says that the update has been done and to restart domoticz but in fact the version is still 0.5.5 What I am missing?

thx

darrepac commented 3 years ago

Here is the log during update process:

 Updating Plugin:Shelly MQTT translator
2021-04-04 10:32:34.435 (Plugin Manager) Checking plugin "Shelly MQTT" for updates
2021-04-04 10:32:35.404 (Plugin Manager) Calling:LANG=en_US /usr/bin/git status -uno on folder /home/pi/domoticz/plugins/Shelly_MQTT
2021-04-04 10:32:35.467 (Plugin Manager) Git Response:b'On branch master\nYour branch is behind \'origin/master\' by 16 commits, and can be fast-forwarded.\n (use "git pull" to update your local branch)\n\nChanges not staged for commit:\n (use "git add <file>..." to update what will be committed)\n (use "git checkout -- <file>..." to discard changes in working directory)\n\n\tmodified: mqtt.py\n\tmodified: plugin.py\n\nno changes added to commit (use "git add" and/or "git commit -a")\n'
2021-04-04 10:32:35.468 (Plugin Manager) Calling: "LANG=en_US /usr/bin/git pull --force" on folder /home/pi/domoticz/plugins/Shelly_MQTT
2021-04-04 10:32:36.420 (Plugin Manager) Git Response:b'Updating c5efbc6..0636aee\n'
2021-04-04 10:32:36.420 (Plugin Manager) Succesfully pulled gitHub update: c5efbc6..0636ae for plugin Shelly MQTT translator
2021-04-04 10:32:36.420 (Plugin Manager) ---Restarting Domoticz MAY BE REQUIRED to activate new plugins---
darrepac commented 3 years ago

Seems there was a git conflict (local changes). Could be nice to handle it in the GUI (at least copy the git error message)