Use is_a?(Enumerable) instead of respond_to?(:size) to detect collections

dmolesUC commented 2 years ago

What is the current behavior?

Non-collection objects with size attribute are mistakenly treated as collections, causing serialization to fail (see #75).

Only Enumerables are treated as collections, cf. the corresponding method in jsonapi-serializer.

Fixes #75.

Please make sure the following requirements are complete:

[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] All automated checks pass (CI/CD)

It looks like the build may be currently failing for other reasons?

stas commented 2 years ago

@dmolesUC any reason we don't want to switch to directly call JSONAPI::Serializer.is_collection? ?

stas commented 2 years ago

Ah, nvm, just saw you answered in the issue. I'll merge this and fix the CI. Sorry about that.

dmolesUC commented 2 years ago

@stas ~~It looks like the build is failing due to an unrelated RuboCop failure.~~ Oops, never mind — I see you saw that.