Refactor ActiveModel::ErrorSerializer

[mamhoff]

What is the current behavior?

No behavior change, but the ActiveModel::ErrorSerializer reads much nicer.

Checklist

Please make sure the following requirements are complete:

• [ ] Tests for the changes have been added (for bug fixes / features)
• [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
• [ ] All automated checks pass (CI/CD)

[mamhoff]

I'm not the maintainer, just did this particular refactoring. So that decision would be on you and @stas.

Aaron Roberts @.***> schrieb am Mo., 15. Juli 2024, 19:26:

@.**** commented on this pull request.

In lib/jsonapi/active_model_error_serializer.rb https://github.com/stas/jsonapi.rb/pull/98#discussion_r1677874718:

 end

 attribute :source do |object, params|

• errorkey, = object
• error_key = object.attribute

if this is more correct i can update on my end. we were building up these errors manually (for some unknown reason) which this suddenly broke.

— Reply to this email directly, view it on GitHub https://github.com/stas/jsonapi.rb/pull/98#discussion_r1677874718, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFLXKJTQNT4EJVGWFJCK4TZMPIHJAVCNFSM6AAAAABJYJ4CW2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZXG44TGNJSGQ . You are receiving this because you authored the thread.Message ID: @.***>