search

stasel / WebRTC

Unofficial distribution of up to date WebRTC framework binaries for iOS and macOS
Other
356 stars 75 forks source link

Fix catalyst builds #52

Closed tmolitor-stud-tu closed 1 year ago

tmolitor-stud-tu commented 1 year ago

Using WebRTC with catalyst results in this error: "codesign failed: bundle format is ambiguous (could be app or framework)" It turns out this is because of a missing symlink in "ios-x86_64_arm64-maccatalyst/WebRTC.framework": WebRTC should be symlinked to point to "Versions/Current/WebRTC".

The binary at "Versions/Current/WebRTC" on the other hand is the wrong one (no multi arch) and should be removed in favor of "ios-x86_64_arm64-maccatalyst/WebRTC.framework/WebRTC"

This PR executes this whole shell game.

stasel commented 1 year ago

Thanks a lot for your contribution! ❤️

tmolitor-stud-tu commented 1 year ago

Thanks a lot for your contribution! heart

You're welcome! :)

Are you sure removing the code that creates the symlink still works for catalyst apps? https://github.com/stasel/WebRTC/commit/b4ab1630a53880916dbb153c2368bc28d85110b1#diff-3d64996115d0ac3b74e36f57ce6b00d6b4982614c41b1ed39eab8ef43b2e9a2bL186

I've not yet reverted my app to your upstream repo to test it myself, but I'm curious if you already tested it.

stasel commented 1 year ago

Yeah I tested it on my machine and it builds successfully I found out that there is no need of creating the symlink because in the previous copy stage, I already have a .framework file with that symlink. This is actually very similar to the macOS step so I decided to keep it the same.

Please let me know if it works for you or have any issues

tmolitor-stud-tu commented 1 year ago

Ah, perfect, thanks! :)

tmolitor-stud-tu commented 1 year ago

It works! :)