search

stasemsoft / softwarematerial

Open software-material used by FHICT (Fontys Hogeschool voor ICT).
Creative Commons Attribution 4.0 International
5 stars 21 forks source link

fix dead links in README.md #27

Closed senn59 closed 1 year ago

senn59 commented 1 year ago

Saw 2 dead links that redirect to a file that no longer exists at that location, Also changed one link that goes to a file inside of the repository instead of stasemsoft.github.io.

coentjo commented 1 year ago

Dear Senna, Thank you very much for your pull request! If you have more ideas/remarks please don't hesitate!

I just tried the links you suggested to change, and in Firefox, Safari and Chrome they seem to work for me? :-? Which browser are you using?

I tried the following links on the page: https://stasemsoft.github.io/softwarematerial/

Any idea?

Thanks, Coen

senn59 commented 1 year ago

Yes they work for me on the github.io link but not inside of the github.com repo e.g. intro links to https://github.com/stasemsoft/softwarematerial/blob/master/docs/personas/intro which gives a 404. I could have misunderstood it being an issue though as I assume you arent really supposed to navigate the docs on the repo page and are supposed to do it on the github.io page.

coentjo commented 1 year ago

Yes, it is indeed supposed to be read from a browser. Most links in the git will however work locally, but the ones in the root-README are an exception, bcause the gh-page-config is set to publish files inside the docs directory, and the global lREADME is not inside...

So if you agree I would like to close this issue now.

Anyway, thanks for mentioning!