search

stashapp / CommunityScripts

This is a public repository containing plugin and utility scripts created by the Stash Community.
https://docs.stashapp.cc/add-ons/
GNU Affero General Public License v3.0
190 stars 147 forks source link

[stash-watcher] script broken by watchdog 5.0.0 #425

Open YonderboyLupus opened 2 months ago

YonderboyLupus commented 2 months ago

Starting with version 5.0.0 released last week, the watchdog library enforces passing keywords with keyword arguments: https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst#500

Now when the script is run with latest requirements an error is thrown by this line: eventHandler = PatternMatchingEventHandler(patterns, None, False, True)

This could be fixed either by adding the appropriate keywords to each call to watchdog methods, or by pinning watchdog<5 (which worked for me). In any case, it would be good to pin the dependencies to known working versions to prevent it from breaking again in the future.

DogmaDragon commented 2 months ago

@DuctTape42

David-Maisonave commented 2 months ago

FYI: Plugin FileMonitor is working with the new watchdog version, and (IMHO) it's easier to use and has more features than [stash-watcher].