stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
8.93k stars 780 forks source link

[Feature] Only one step away from full DeoVR support. #2116

Closed philpw99 closed 2 years ago

philpw99 commented 2 years ago

Is your feature request related to a problem? Please describe. Need to have a stream link with file extension like .mp4 or .mkv so DeoVR can play the scene.

Describe the solution you'd like Add a stream link with file extension, like "http://192.168.1.10/scene/123/stream.mp4".

Describe alternatives you've considered A "Launch File" button? Which will open the local file directly, not through the web interface.

Additional context Stash has been my favorite porn organizer since I discovered it. I wrote an app to help me launch the DeoVR player to play a scene I selected from the browser. It works well for me.

The reason I want this feature, because I see right now Stash has come so close to fully support the DeoVR playback. Just a little modification, and DeoVR will be working great with Stash, either with Quest 2 remotely, or with other HMD locally.

Right now in DeoVR, I can browse the movies like this: s1

Then view the movie poster like this: s2

Then go in to the scene like this: s3

It's almost perfect, except the stream link doesn't work yet. ( The file link doesn't work either because web browser cannot access local files.) DeoVR just need a link with file extension, like "http://192.168.1.10:9999/scene/123/stream.mp4", and it's done. No need to re-encoding or remuxing, just serve the original file with "stream.mp4" or "stream.mkv". DeoVR player will happily take over from there.

philpw99 commented 2 years ago

Also if we implement this, there is no need for DLNA serving for DeoVR users any more. We can just view and play the files directly from the browser.

kermieisinthehouse commented 2 years ago

2105

Caleripo commented 2 years ago

But this has nothing to do with DeoVR specifically right? This would enable the basic ability to support VR playback for all VR browsers (e.g. Oculus Browser, Skybox,…) not only DeoVR. What I understand as DeoVR support is using the DeoVR interface API (https://deovr.com/app/doc/webvr-video), which would also introduce a nicer interface to navigate stash in VR.

philpw99 commented 2 years ago

2105

This is different than the JSON approach. I tried JSON before, and it requires a HTTPS connection. Yet if we use a direct file name, suddenly it works without https.

philpw99 commented 2 years ago

@Caleripo Oh, yes, what you said is true. This feature will help not only DeoVR, but also all other VR media players in general. It will also help regular 2D media players which has problems playing the stream. The DeoVR interface is not reliable, because even now the web-hub is still not working. I hope they could make WebVR player better, but now it's not as solid as simple "GET" files.

SilentSpartan commented 2 years ago

I hate DEO but love Skybox. So if it helps browsing through Stash on there as well, I'm all for it.

kermieisinthehouse commented 2 years ago

This is actually already supported. You can add .mp4, .webm, .mkv, .ts, .m3u8 to the end of a stream url and get the video streamed in the requested format.

philpw99 commented 2 years ago

Wow, why only now I see this ?! I am so stupid not to check this !! Thank you @kermieisinthehouse for telling me this. This is wonderful news to me !

philpw99 commented 2 years ago

Sorry, but it turns out the "stream.mp4" or "stream.mkv" are extremely slow because they are not directly served. So once again, this issue is not resolved, but I think it's better just keep it closed.