search

stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
9.32k stars 799 forks source link

[Bug Report] Console is appearing again on stash.exe launch as of 0.15.0 #2598

Open hphpanon opened 2 years ago

hphpanon commented 2 years ago

Describe the bug Release 0.13.0 introduced the behavior that Stash would open solely in the systray and no longer open a console window. 0.15.0 has regressed that. Most likely related to https://github.com/stashapp/stash/pull/2543 (which directly manipulated behavior around Windows console stuff, but I'm no Go expert).

The stash icon appears in the systray, but I also get the terminal window, which I wasn't getting as of 0.13.0 and don't want anymore.

To Reproduce

  1. Launch a 0.15.0 stash.exe on Windows via double-click in Windows Explorer

Expected behavior Stash running with just the stash icon in the systray. No terminal window.

Screenshots image

Stash Version: (from Settings -> About): v0.15.0 (build hash b2ac0223)

Desktop (please complete the following information):

Additional context As hopefully evident in the screenshot, I've changed the default console/terminal app to Windows Terminal instead of the legacy Command Prompt app. I can't imagine that's particularly relevant to the behavior in question, but figured I'd mention it just in case.

hphpanon commented 2 years ago

As hopefully evident in the screenshot, I've changed the default console/terminal app to Windows Terminal instead of the legacy Command Prompt app. I can't imagine that's particularly relevant to the behavior in question, but figured I'd mention it just in case.

After looking through #2543, it appears this is actually extremely relevant. If I set my default terminal app to the legacy command prompt app, it behaves as expected. However, previous versions of Stash did not have this limitation, so this is still a regression in my eyes.

MrX292 commented 2 years ago

does the console stay open? for me it closes after a couple of seconds and is only in the systray.

hphpanon commented 2 years ago

Yes, it stays open.

hphpanon commented 2 years ago

If i set my default terminal to the legacy Command Prompt it works as expected (shows up briefly and then disappears) but with it set to Windows Terminal, it stays open as long as stash is running. In Stash 0.13.x and 0.14.0, it was fully compatible with Windows Terminal being the default terminal app.

WithoutPants commented 2 years ago

This looks like the same bug as https://github.com/nzbget/nzbget/issues/792

There is also a workaround posted in that issue. Could you see if that resolves the issue for you?

hphpanon commented 2 years ago

Yup, that works. It looks like Microsoft is working on making Windows Terminal support some of the functionality in question, so it might Just Work™ in a future Terminal update (assuming there's nothing else that can be done on the stash side of things).

In any case, I can once again have stash happily run in the background. I'll leave it up to you whether this should be closed (since it has a valid workaround) or stay open. Thanks for finding that!

djbtwothousandtwenty commented 2 years ago

Bumped into this one starting somewhere last week as well, but in my case it's because of 2 things:

This means this will likely happen to a lot more people as soon as this update reaches the mainstream windows 11 users.

Phasetime commented 2 years ago

Workaround for me is running stash as admin. It seems to not run in Windows Terminal then and works fine again, even with Windows Terminal being the default terminal.

WeedLordVegeta420 commented 2 years ago

Using a shortcut that starts stash directly through conhost.exe as suggested in https://github.com/nzbget/nzbget/issues/792 worked for me.

xx790 commented 1 year ago

Still an issue. Made wt the default terminal and got this issue. The mentioned workaround with conhost link does work.

Stash:

v0.21.0
Build hash 9180a68c

OS:

Edition  Windows 10 Pro
Version  21H2
OS build 19044.3086

Windows Terminal: 

1.17.11461.0

Interestingly, the issue https://github.com/microsoft/terminal/issues/12570 was closed more than a year ago, saying the issue was resolved in Windows Terminal Preview v1.14.143. I presume the fix should be in 1.17.11461.0 as well by this time. This might mean that additional work is still required to resolve the issue.