stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
8.78k stars 778 forks source link

Captions sometimes require 2 scans to pick up everything #2619

Open cj12312021 opened 2 years ago

cj12312021 commented 2 years ago

Describe the bug Sometimes it can take two scans to pick up all provided captions. The problem is that the scene isn't always guaranteed to be processed before its provided captions get processed. If a caption is scanned before the scene it belongs to, that caption doesn't get associated with anything, so a second scan would be required. We could consider waiting to associate the captions found during a scan until the end.

Expected behavior Captions should be able to get associated correctly with one scan.

Stash Version: v0.15.0:

WithoutPants commented 6 months ago

The current implementation of caption handling also causes an already in transaction error during folder rename detection.

feederbox826 commented 2 weeks ago

Duplicate of #3800 but it seems like a selective scan is needed