stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
9.25k stars 794 forks source link

[Bug Report] Weight box errors out if inputting letters #2631

Open FormBurden opened 2 years ago

FormBurden commented 2 years ago

Describe the bug When inputting any kind of "Weight" that involves non-numbers will cause the "Weight" window to error out.

To Reproduce Steps to reproduce the behavior:

When creating a performer, from scratch or from auto-created from site and you decide to scrape or manually put in info, the "weight" will error out if you put anything other than numbers (i.e lbs, kg, etc)

Expected behavior To work like other boxes where you can put info other than numbers and it'll still work.

Screenshots Screenshot_20220527_163907

Stash Version: (from Settings -> About):

0.15.0

Desktop (please complete the following information):

Smartphone (please complete the following information):

Have not tested.

stg-annon commented 2 years ago

So it might not be super intuitive but Stash expects the Weight and Height fields in metric which is why it is erroring its tying to enforce that, to that effect scrapers are designed to automatically convert these measurements to the expected units, in the future there may be an option to change the value that will be displayed but that would be converting it from the standardized value from the DB just for display

FormBurden commented 2 years ago

While I get that, I'm just saying, that even for height, you can put any kind of lettering in, not just 5'10", or 50cm, etc., you can write out whatever, "jklljk;" for example, but it will convert to "NaNcm" that error. But even height it seems to not convert well anyway, like if you put 5'10", it'll just say 5cm. Some scrapers include the lbs/cm etc., text when it fills in. But you have to delete it or you won't be able to click save at all. So it slows the processing down.