stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
8.54k stars 764 forks source link

[Feature] Meta tags - Tag edit option to hide tag from dropdown lists #2633

Open echo6ix opened 2 years ago

echo6ix commented 2 years ago

Is your feature request related to a problem? Please describe. More of us are are organizing tags into nested hierarchies, but some of the parent tag categories aren't necessarily tags that are applied to content. They are simply categorical parent placeholders.

For example on StashDB, the "BBW" tag is nested under the "Body type" category. On Stash, the "Body type" category would be a parent tag and set to "ignore auto tag".

Describe the solution you'd like To add a toggle switch/checkbox within each tag's option to disable the tag from being displayed in dropdown lists and from being used by scrapers.

Tag > Edit > [toggle] Hide tag from dropdown list and scrapers

ghost commented 1 year ago

I would prefer to hide all parent tags. I don't like the suggested solution of having to edit every parent tag.

ALonelyJuicebox commented 1 year ago

I would prefer to hide all parent tags. I don't like the suggested solution of having to edit every parent tag.

I would argue your opinion is in the minority. I mean, just consider the following tags

Doggystyle Doggystyle (POV) Doggystyle (Anal)

There are plenty of instances where any of these three tags make perfect sense to add to a scene. Hiding all parent tags (in this case, the "Doggystyle" tag would be hidden) doesn't make sense.

DogmaDragon commented 1 year ago

I would prefer to hide all parent tags. I don't like the suggested solution of having to edit every parent tag.

Hiding certain parents is not a bad idea, like the ones mentioned in the proposal. But making a general toggle is not great.

Some people have complicated hierarchies with multiple parents.

7dJx1qP commented 1 year ago

I would prefer to hide all parent tags. I don't like the suggested solution of having to edit every parent tag.

The solution to not having to edit every parent tag should be to add a bulk edit option on the tags view page like scenes, performers, movies, etc have. Then you could just filter by sub-tag count > 0 and mass update them. The current "Ignore Auto Tag" should be bulk editable as well. It would also be nice to be able to set a bunch of parents and children all at once via bulk edit. I put in a feature request for such a tag bulk edit a while ago https://github.com/stashapp/stash/issues/1836

feederbox826 commented 2 months ago

Addressed in plugin

echo6ix commented 2 months ago

Just to prevent this FR from being closed, this plugin does have one important limitation, making it more of a stopgap measure -- it won't prevent scrapers from ignoring these "meta tags" from populating in the tag react-select forms.

That's probably one of the more annoying aspects of using "meta tags" with Stash. I cannot recall which major studios this was happening on, but a meta tag like "breasts" was actually getting scraped and populated. An obvious user workaround is to manipulate your meta tag names. For example, adding prefix character such as . to the label: breasts --> .breasts. Bad long term solution though.

Thanks again @feederbox826 for the plugin, and I mean no disrespect when I say the plugin is a stopgap because I will use it, and appreciate the time you took to create it. 😍

feederbox826 commented 2 months ago

that might be possible, I'll have to do more testing on the backend