stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
9.09k stars 788 forks source link

[Bug Report] Scene Tagger scrape returns deleted stashbox scenes #2867

Closed 7dJx1qP closed 8 months ago

7dJx1qP commented 2 years ago

Describe the bug Deleted stashbox scenes appear in the scrape match results when using the scene tagger to scrape a stashbox source with Scrape all or Scrape by fragment

To Reproduce Steps to reproduce the behavior:

  1. Go to Scene Tagger
  2. Click on "Scrape by fragment" for a scene that has duplicate stashbox entries, one of which is deleted
  3. See duplicate entries in match results, including deleted one.

Expected behavior Only stashbox scenes that aren't deleted should be returned

Stash Version: (from Settings -> About):

Desktop (please complete the following information):

Additional context Deleted scenes are only returned when scraping. Using "Search" instead of scrape returns only the non-deleted scenes as expected

Here's a pair of stashdb scenes, one of which is deleted, that can be used as a test case: https://stashdb.org/scenes/6df5a699-a4c3-476b-81d8-70477ad1ba17 https://stashdb.org/scenes/6b4cd19d-d52a-4a30-a2f5-949793db6e49 Another pair: https://stashdb.org/scenes/497c8cb4-655b-47ad-af99-8da2266e4d36 https://stashdb.org/scenes/2b3fa512-5f3f-453f-bf58-7abcd5969b7c

peolic commented 2 years ago

This has been mentioned before, but I guess it was never reported on GH. The underlying reason is users can submit fingerprints to deleted scenes, then they get matched and show up in the results.

peolic commented 1 year ago

Should be fixed now. (stash-box v0.3.0)

Maista6969 commented 8 months ago

Can be closed