stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
9.34k stars 803 forks source link

[Feature] Video.js Rating Stars #3250

Open elkorol opened 1 year ago

elkorol commented 1 year ago

Is your feature request related to a problem? Please describe. Having to go into the edit panel to rate scenes is cumbersome, I end up tending to avoid rating scenes when in fact want to.

Describe the solution you'd like I propose, a video.js plugin that superimposes rating stars onto the video player itself. Right aligned next to playback rate, there's a lot of space there that's without going to overboard unutilised (I have another idea for a video.js UI element, I'll add after this one).

I think the colour scheme of the stars would be better in align with the current UI colour of other elements of the video player. So white stars

Describe alternatives you've considered I've considered using injectable javascript to achieve the same but my knowledge of React is limited.

Additional context

485648
skier233 commented 1 year ago

Would be nice. But would also need to work with other rating systems than the stars (ie decimal).

StashPowerUser commented 1 year ago

Being able to instantly rate scenes playing fullscreen would be excellent.

DogmaDragon commented 1 month ago

Would you consider this solved now that the ratings are available outside of Edit tab?

StashPowerUser commented 1 month ago

I would not until one click star rating is available in full screen.

DogmaDragon commented 1 month ago

@StashPowerUser you can use keyboard shortcuts for that https://docs.stashapp.cc/in-app-manual/keyboardshortcuts/#edit-scene-tab-shortcuts

StashPowerUser commented 1 month ago

Yeah, but the ratings aren't visible and the keyboard isn't always as convenient.

cj12312021 commented 1 month ago

I would consider this issue completed. The star rating is no longer isolated to a specific tab, effectively addressing the pain point in the original comment. The source code is unlikely to place the rating directly in the video player. Since the rating is no longer isolated to a tab, it is much more flexible for users to relocate it via CSS or a plugin. This issue could be moved to the scripts repo if further work is requested.