stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
8.87k stars 780 forks source link

Movies section Bugs & Suggested Improvements #398

Open VonTittyslappen opened 4 years ago

VonTittyslappen commented 4 years ago

Hi all

I've been building a list of Bugs & Suggested Improvements for the Movies section.

If you want to contribute any bugs and suggestions please post and I'll update the first post with them.


Bugs


n/a (previous bugs resolved in latest UI layout)


Improvements


1a. Capability to assign a studio when adding the Movie into the database, rather than having to add studio per individual scene. 1b. Further enhancement would be the capability to assign a movie to scenes via the tick boxes in the top left of all scenes (currently this can only be done for rating, studio, performers & tags). This would save a lot of time in allocating scenes to movies). Both 1a & 1b will be time savers.

  1. Add more than a maximum of 10 Scene numbers (perfect example of this is the Suck It Dry series from Evil Angel that has up to 18-20 scenes!), suggest a maximum of 20.
  2. Allow functionality to increase size of the cover art when hovering the mouse over it on the movie page (perhaps optional?). Or alternatively, allow functionality where if you left click the cover art it makes it bigger in size.
  3. Add the zoom slider on the Movies section
  4. Show the scene number when hovering the mouse over the movie icon
  5. Add producer option when adding/editing movies (ie. Brazzers)
  6. Add studio option when adding/editing movies (ie. Dirty Masseur / Mike Adriano Productions)
  7. Allow options to show movie duration in either minutes or in seconds
  8. Add optional functionality where it can count the minutes of total scenes within a movie and display it (rather than entering manually)
  9. Add number box to input how many total scenes the movie has (therefore you know if you are missing one or more) - IAFD scraper could potentially pull this info automatically in the future looking at the scene index list.
  10. Scenes in the movie pages should auto sort in Scene number order by default

Cheers

WithoutPants commented 4 years ago

Pigbacking off this issue for a bug: the scene -> movie relationship table has a unique index on movie id and scene index, meaning that you cannot assign the same movie id/scene index combination to more than one scene. I think this unique constraint should be between movie id and scene id, not the scene index.

Will try to combine schema updates for the fix of this issue, adding studio, and also making movie name not null.

brokje commented 4 years ago

I add here some extra nice features:

  1. Show the scenenumber when hovering the movie icon
  2. Producer (e.g. Brazzers)
  3. Studio (e.g. Dirty Masseur)
  4. Make duration in minutes only (or even better, count minutes of scenes within the movie?)
  5. Add numberbox on how many it containts, so you know if you are missing some.
bnkai commented 4 years ago

Moving #403 here and closing it.

Add a default sort order filter for scenes in the movies page so that they are sorted by index position in movie.

WithoutPants commented 4 years ago

@VonTittyslappen can you do another pass with the v2.5 UI and update the list? I suspect some things can be resolved (and possibly new ones added).

VonTittyslappen commented 4 years ago

@VonTittyslappen can you do another pass with the v2.5 UI and update the list? I suspect some things can be resolved (and possibly new ones added).

@WithoutPants sure, will do!

VonTittyslappen commented 4 years ago

First post has now been updated with the most recent suggestions :)

WithoutPants commented 4 years ago

Add producer option when adding/editing movies (ie. Brazzers)

Would this not be better handled by parent studios?

WithoutPants commented 4 years ago

Allow options to show movie duration in either minutes or in seconds

458 is changing the duration field in the schema to an integer. I think we need to make a design decision now as to whether to store the movie duration in minutes or seconds. If we want to allow optionally setting to second granularity, then the duration must be stored in seconds in the database. Otherwise, we can just store the duration in minutes and accept only hh:mm.

We could possibly change the duration control in movies to interpret xx:yy as hh:mm, instead of mm:ss as it is currently. My concern there is that it makes it inconsistent with the duration fields in other areas (scenes, markers for example). This could be mitigated somewhat by changing the placeholder and/or field label to indicate hh:mm[:ss]. It might also help to change the value to h hours m minutes [s seconds] when in view/read-only mode.

bnkai commented 4 years ago

Imho we should store as seconds to keep everything consistent. The ui or the graphql query can then decide what it wants , eg minutes.

firrets commented 1 year ago

Suggestion to remove the unique constraint from movies.name Movies from different years can have identical names. E.g. Obsession from 1991 and 2001