stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
8.59k stars 770 forks source link

[Feature] Add option to Generate thumbnails for image files #4189

Closed JoeShymoe closed 5 months ago

JoeShymoe commented 10 months ago

Is your feature request related to a problem? Please describe. Currently it is not possible to change image thumbnails after they are initially scanned.

Describe the solution you'd like Stash has options under the Generate heading to do similar things for a number of other options. It would be useful if image thumbnails was added to that list.

Describe alternatives you've considered Delete the images from stash and rescan them.

xantror commented 10 months ago

Implementing this will also help people who did not choose to generate image thumbnails during scan but do want to generate them later.

Currently, when they are generated during a scan, it respects the Number of parallel task for scan/generation setting.

When they are generated automatically while browsing, stash currently tries to generate thumbnails for all images on the page at the same time, which might lead to stash crashing due to OOM when there are many large images (I've had stash crash due to this).

Dark-Obsidian commented 10 months ago

+1

From the above, I am taking it that stash doesn't generate a new thumbnail when it detects an ohash change (i.e. the image has changed)?... If not then yes, this would be good to add.

elshanta commented 9 months ago

I have the same issue here. I scanned thousands of image galleries without Generate previews for image clips option and now it is imposible to rescan them to generate missing image thumbnails:

Captura de Pantalla 2023-10-20 a la(s) 12 58 00
Ksrx01 commented 9 months ago

might lead to stash crashing due to OOM when there are many large images.

Well this explains a lot. I'm currently experiencing the same issue.

elshanta commented 9 months ago

Please consider both folder galleries and zip galleries 🙏

DogmaDragon commented 9 months ago

@elshanta please make a separate issue. Tailored issues allow for faster development.

Ksrx01 commented 9 months ago

Please consider both folder galleries and zip galleries 🙏

Kinda OT and I don't want to sound presumptuous, but I switched a rather extensive library from folder to zips. If you don't access those folders by means other than Stash, it has a number of advantages that shouldn't be discarded, especially from a storage point of view.

elshanta commented 9 months ago

Please consider both folder galleries and zip galleries 🙏

Kinda OT and I don't want to sound presumptuous, but I switched a rather extensive library from folder to zips. If you don't access those folders by means other than Stash, it has a number of advantages that shouldn't be discarded, especially from a storage point of view.

thanks for the recommendation.

elshanta commented 7 months ago

Any kind soul who can start this on the backlog please 🙏 Should be a quick fix.

elshanta commented 1 month ago

This was partially solved but there are still some cases where galleries have empty thumbnails.

Captura de pantalla 2024-06-22 a la(s) 15 38 47