stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
9.26k stars 794 forks source link

[Feature] Enable `Scene Tagger` to have its own default view #4220

Open Dark-Obsidian opened 1 year ago

Dark-Obsidian commented 1 year ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

DingDongSoLong4 commented 1 year ago

Saved filters also save the view (ie disp=), so what I have is a saved filter that will automatically take me to the Tagger view and apply relevant filters and sorting as well (eg Stash ID is null). This is one more click than just clicking the Tagger view, but I don't think that's too big of a deal.

If we're going to have separate default filters for the Tagger view, then I don't see why we shouldn't also have default filters for the other views too.

I imagine the reason for your redirection loop is because the URL you're redirecting to (http://localhost:9999/scenes?c=("type":"stash_id_endpoint","modifier":"IS_NULL")&<<params>>disp=3) also matches the format of the URL you're redirecting from (http://localhost:9999/scenes?<<params>>disp=3). You'll need to add additional logic to prevent the loop, perhaps to only redirect if there is no stash_id_endpoint filter already present in the URL.

Dark-Obsidian commented 1 year ago

Hi @DingDongSoLong4 -- thanks for the reply...


RE: Saved filters per disp=

Sure, get what you're saying and have done the same thing myself but the crux of the request was really around being able to set a different default saved filter for Scene Tagger if possible, as have found myself...

  1. Going to Scenes (default Scene saved filter applies)
  2. Opening Scene Tagger
  3. Doing a Scrape All / Search All
  4. Realising I have scraped/searched scene that are already tagged
  5. Having to select my Scene Tagger Default saved filter
  6. Re-run the Scrape All / Search All
  7. Go through and tag my scenes

So the goal of this request is to essentially eliminate possibility of having to go through steps steps 4 - 6 and streamline the tagging process.


RE: Redirection loop

Thanks for the suggestion, I thought I had covered this - see rule export below...

In the process of writing the above though, I actually spotted the error...

DingDongSoLong4 commented 1 year ago

@Dark-Obsidian

This is my usual tagging "workflow":

  1. Go to Scenes (applying the regular saved filter)
  2. Click Saved filters > Tagger Studio. This is a saved filter which sets ?c=("type":"studios","modifier":"IS_NULL")&sortby=created_at&sortdir=desc&disp=3: filter by Studios is null, sort by Created At (desc), and the Tagger view (disp=3). I also have a few other Tagger saved filters, each with different filters (eg Stash ID is null), but the rest is the same.
  3. Tag scenes.

If I understand correctly, you want this:

  1. Go to Scenes
  2. Click the Tagger icon, and automatically have a tagger-specific default filter applied (ie for me, the Tagger Studio filter)
  3. Tag scenes.

Yes my workflow has an extra click (the Saved filters button), but I don't really think that's a big deal.

From a user expectation perspective, the Tagger is just another "view" in the scenes page, and since saved filters also include what "view" you're in, it doesn't in my opinion make sense to have separate default filters for only the Tagger.

Perhaps the solution is to completely separate the Tagger from the other views, where then it would make sense to have separate default filters. You wouldn't use the Tagger view to browse, and you wouldn't use the Grid/List/Wall views to tag scenes - there's a clear logical distinction there, but they are all treated "equally" as views.

Dark-Obsidian commented 1 year ago

Thanks @DingDongSoLong4, some good points to consider...


Your approach: 👍🏼


"From a user expectation perspective, the Tagger is just another "view" in the scenes page"

User "mode"

I also think that it is worth considering the user's "mode", i.e. primary thing they are trying to achieve at this moment in time...

1. Browse/View

2. Organise/Import

DingDongSoLong4 commented 1 year ago

I agree with you entirely - the use cases for Grid, List and Wall are entirely separate from the Tagger. The Tagger serves a very different purpose, that being organising/importing content, rather than viewing it.

What I meant was that this distinction isn't being clearly communicated in the UI - Grid, List, Wall and Tagger are all grouped together as views of the Scenes page. Your highlighting of the Scene Tagger button (and the fact that we have to tell people "click here to efficiently tag your scenes") I think shows a deficiency in the UI design/layout.

I think the Tagger should be clearly separated from the other "views" - maybe it could have an entirely different layout (eg using a different header), a different way of accessing it - something to clearly show that it is for a separate "user mode" as you put it. I'm not a UI designer by any means - these are just some ideas that I imagine could improve the overall experience.

scruffynerf commented 1 year ago

+1 to @Dark-Obsidian 's take. Let's do the Scene Tagger icon change asap, and then discuss bigger revamps