[Feature] Make scene video filter settings per scene persistent

stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc

https://stashapp.cc/

GNU Affero General Public License v3.0

9.34k stars 802 forks source link

[Feature] Make scene video filter settings per scene persistent #4345

Open echo6ix opened 11 months ago

echo6ix commented 11 months ago

Is your feature request related to a problem? Please describe. Scene video filter settings are not persistent per scene. They must be recalibrated each time the same scene page is clicked.

Describe the solution you'd like To make the scene video settings persistent per scene

Add a Save button perhaps
Some kind of indication that the video filters have been modified beyond their default state
- This could be as simple as showing the string label (modified) beside the filter heading inside the filter tab

EDIT: Clarified persistence would be per scene

DingDongSoLong4 commented 11 months ago

Would the persistence be per-scene, or globally for all scenes? Global is of course easier to implement, but perhaps per-scene is more useful? I don't ever use the filters, so I have no idea.

echo6ix commented 11 months ago

Would the persistence be per-scene, or globally for all scenes? Global is of course easier to implement, but perhaps per-scene is more useful? I don't ever use the filters, so I have no idea.

Great question. I really should have clarified that in the post. Persistence would be per scene.

I find the transform filters useful specifically the scale slider when the video isn't to scale.

elkorol commented 10 months ago

I already did this mate with persistence per scene with this pull request 4026

It's got conflicts now but it worked in the last version

echo6ix commented 10 months ago

I already did this mate with persistence per scene with this pull request 4026

It's got conflicts now but it worked in the last version

Cool. Should I close this thread or leave it open until the feature works again in a develop release?

DingDongSoLong4 commented 10 months ago

@elkorol apologies, forgot about that PR - I'll try to check it out next week.

@echo6ix I think we might as well leave this open, I'll link the PR to this issue so it will auto-close once the PR merges.

elkorol commented 10 months ago

@elkorol apologies, forgot about that PR - I'll try to check it out next week.

@echo6ix I think we might as well leave this open, I'll link the PR to this issue so it will auto-close once the PR merges.

No worries, thanks for taking a look into it

ariv-x commented 2 weeks ago

Following the links, it looks like PR #4520 is the latest attempt at implementation. Any chance of this getting merged soon?