search

stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
9.09k stars 788 forks source link

Page filters no longer sticking after page refresh #4554

Closed floydcg closed 7 months ago

floydcg commented 8 months ago

Just loaded the latest develop build and it appears that if you apply a filter, such as : is missing > Performer, if you refresh the page the filter is no longer applied, I went back to v0.24.3-30-ga16f3da3 (the last build I had before updating to v0.24.3-38-gdad4ab6a and the filter sticks on refresh.

floydcg commented 8 months ago

Also wanted to add that the URL has the correct filter in it, (&c=("type":"is_missing","value":"performers","modifier":"EQUALS")&sortby=date) but the filter isn't applied to the view unless you go and reload the filter by hand

WithoutPants commented 7 months ago

I'm unable to reproduce this on v0.24.3-44-g440c261f5.

Steps I tried:

  1. Open scenes page
  2. Edit filter -> missing performer
  3. Verified only scenes missing performers were shown
  4. Refreshed the page
  5. Verified same filter was applied
floydcg commented 7 months ago

Looks like whatever was causing it must have been fixed then in this build, on the previous one mentioned, I tried 3 different browers and all were the same. I'll go ahead and close this

floydcg commented 7 months ago

Triggered it a different way, added a filter for stashid under a studio, put in the URL of TPDB which gave results missing that stashbox id, refreshed page and it returns all records with all the filters gone this time. the URL is also missing the filters it previously had. It never updates from what I can tell. it stays (in this instance as http://localhost:9999/studios/1029) where previously when you would apply filters the URL would update to include all the filters.

floydcg commented 7 months ago

userscripts/userscript plugins also seem to be broken on studios at least. Rolling back to v0.24.3-30-ga16f3da3 gives me this : image

but if I update to v0.24.3-44-g440c261f5 image looks to be related to the URL missing the the filtered values

WithoutPants commented 7 months ago

Can you please provide specific step by step instructions on how to reproduce this? I'm still unable to reproduce with the new instructions provided.

floydcg commented 7 months ago

All I've had to do is apply a filter, so if I go to a studio with say 344 entries and add the filter stashid is null, which it will return the results of is null so say 13 entries. If you then reload the page via browser refresh, the filter will be gone and 344 scenes will be returned again. I've disabled all plugins, all custom CSS and tried Firefox edge and chrome (Firefox was never used previously) and all of them remove the the filters and return all results. The URL also always stays to the studio ID number now without any filter following it. The reason for the refresh in my case was sometime the colorizer plugin won't apply or the search all/save all buttons won't be there. If I go back to the last older dev build I have, it works fine. Going past this build, no amount of refresh will get these to show up and the filters drop off.

WithoutPants commented 7 months ago

Ok, I've managed to reproduce this.

For reference, these are the steps to reproduce - in future, please write steps like the following:

  1. Open the studio detail page for a random studio
  2. In the Scenes tab, add more filter criteria - for example, filter by stash id is null
  3. The URL remains the same as it was /studios/xx and is not updated to include the filter string.

Long form instructions are prone to misunderstanding or incomprehension.

This is almost certainly introduced by #4538.

floydcg commented 7 months ago

My apologies, I'll try and follow that template in the future.