stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
9.21k stars 795 forks source link

[Feature] Prevent installing multiple themes simultaneously #4556

Open rudetuber opened 8 months ago

rudetuber commented 8 months ago

Is your feature request related to a problem? Please describe. Currently, a user can install multiple theme plugins simultaneously, with unpredictable results (one of the installed themes overrides the others).

Describe the solution you'd like The plugin installer should prevent more than one theme from being installed concurrently

Describe alternatives you've considered Alternatively, themes could be broken out into a separate section from plugins. This would allow for adding the logic to make them mutually exclusive as well as other future features such as theme previews.

echo6ix commented 8 months ago

Following Kodi's add-on type/structure, I think this could be prevented by adding a required field to the manifest that designates the category of the plugin, where the category type is derived from a fixed list of categories. For example,

category type description
theme A plugin that changes the general visual appearance of the user-interface
ui A plugin that modifies a specific aspect of the user-interface
module A plugin that does not appear in Stash but provides support for other plugins
etc ...

At least with themes, Stash could use simple logic that only one plugin using the theme category can be installed/loaded at a time. Categories would also improve how we filter plugins, which might be important as more are created.

I am not a dev though. Maybe there is a better way.