stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
8.97k stars 785 forks source link

[Bug Report] Markers causing audio to become messed up #4697

Open LexThorn opened 6 months ago

LexThorn commented 6 months ago

Describe the bug Scene markers that have generated thumbnails are playing the audio for that timestamp on loop once they are reached in the video.

To Reproduce Steps to reproduce the behavior:

  1. Load scene that has markers with generated thumbnails
  2. Play until at least one marker has been reached
  3. Then the bug happens.

Expected behavior I would expect the audio from the marker would only play if the markers tab was open for that scene, and if the video itself was paused.

Stash Version: v0.25.1

Desktop (please complete the following information):

Additional context

WithoutPants commented 6 months ago

This is a very strange bug that I haven't yet been able to reproduce. Have you disabled all plugins and custom css?

LexThorn commented 6 months ago

I did some more checking with changing settings and found that by changing the preview type in the interface settings tab to animated instead of video that it seems to fix the problem.

I also noticed that there was an "Enable Sound" option next to that which was already disabled so I'm unsure if that is supposed to have kept it from playing the audio but it seems to me that the issue might be with how the audio is being played for video previews.

WithoutPants commented 1 month ago

The nearest to reproducing this I was able to get was my flicking my mouse over the marker video in the Markers tab, and only if Enable Sound was enabled in the Interface -> Scene / Marker Wall settings. The video sets the muted field based on if the sound is enabled in the settings, and if it is active. The active field is set based on the animation transition which is buggy on the Scene Markers panel due to the scale not being set in the css.

The most likely culprits for the original bug still seem to be a css related thing, but I haven't been able to reproduce it either way.