search

stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
8.45k stars 749 forks source link

Default view filters #4962

Closed WithoutPants closed 2 weeks ago

WithoutPants commented 3 weeks ago

Supercedes #4036 Resolves #2404 Resolves #4010 Resolves #3079 Resolves #4137

Adapts @yoshnopa's work from #4036. Deprecates the default filter functions from the graphql interface. Instead, all default filter settings are stored in the UI settings. Each view in the UI has its own default filter that can be set.

The default filter is used when the view is loaded without any parameters.

yoshnopa commented 2 weeks ago

Great, just tested it! However, I have an issue left: I added the possibility to have the default filter/view applied on links as well. This does not seem to apply to your commit. That one I still find to be the source of quite some inconsistency. For example, I'd assume that if I click on the gallery symbol of a tag in the front page that it will at the very least use my default view options (basically be the same as if I visited galleries regularly, just with the tag filter as an addition). Or is there a reason that was phased out?

WithoutPants commented 1 week ago

I left it out to reduce the scope. I don't have immediate plans to implement it, but no injection to its inclusion.

Probably needs to be discussed in a separate feature request, but my preference would be that the tag links don't include a sort parameter and that the URL resolution code uses the default filter to determine the sort and view if these aren't provided.