search

stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
8.97k stars 785 forks source link

[Feature Request] no markers on newly created scene from split #5089

Open Lamda604 opened 2 months ago

Lamda604 commented 2 months ago

Describe the bug Markers that existed in a scene with multiple files don't behave correctly after splitting the scene:

  1. Markers stay visible on the timeline of the first scene and tooltip comes up with mouse hover on timeline but markers are no longer listed in the Marker menu of that scene - the menu is now empty. No apparent way to edit or delete them.
  2. A set of markers DO exist in the global Markers screen.
  3. Newly split copy of the scene contains no markers whatsoever.

To Reproduce Steps to reproduce the behavior:

  1. create a scene and add a few markers
  2. merge the scene with another scene
  3. split the scene into two scenes
  4. one scene will have markers on the video playback timeline but no markers will be in the scene's Marker menu
  5. the other scene will not have any markers
  6. a set of markers will still exist in the main Markers view of Stash

Expected behavior After splitting a scene containing markers, at least one scene retaining the markers should also have the markers showing in the scene Marker menu so that they can be edited/deleted.

Ideally any newly created split scenes will inherit the markers - time stamp, tags and title?. Does this function create a new (duplicate) marker in the database/is this allowed? Or can one marker exist in multiple scenes? My guess is you'll opt for the split of a scene to generate new markers with a marker only associated to one scene, name of marker can be the same but have an independent ID in the database to create unique entries as this allows independent editing and generating of previews etc. Or worse: you opt to not copy markers to the new split scene at all *boo! 😝because who want's to remake markers? easier to delete or edit/rename them 😄

Screenshots markers missing in menu

Stash Version: (from Settings -> About): v0.26.2

Desktop (please complete the following information):

WithoutPants commented 1 month ago

I haven't been able to reproduce the markers not appearing in the original scene. Markers are appearing as normal for me.

Duplicating the scene markers into the split scene is not something I considered when I first added the split functionality, and it's not a simple change. There's no guarantee that the secondary files in a scene have the same perceptual contents, and the marker timestamps may not necessarily be valid for the file being split.

I'll consider this as a feature request to optionally duplicate scene markers during the scene split operation.