search

stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
8.79k stars 778 forks source link

[Bug Report] A>B Loop Controls do not work on Apple Touch Devices #5178

Open BonerFide opened 2 weeks ago

BonerFide commented 2 weeks ago

Describe the bug On desktop browsers you can select an A (in) and B (out) time for a video and then turn the loop on. On iOS this does not work in either safari or chrome (both in the non full screen browser where the controls appear). It's possible these controls are only setup to respond to click rather than touch.

To Reproduce Steps to reproduce the behavior:

  1. Open a scene page
  2. On phone may need to use landscape view (not full screen)
  3. Tap either of the 0:00.0 box's or the Loop Off toggle box
  4. Nothing happens
  5. If you repeatedly tap them many many times rapidly you may be able to get it to register as a tap/click.

Expected behavior Tapping on the A/B/Loop On buttons on iOS should work as per the click on desktop.

Smartphone (please complete the following information):

Additional context Upstream bug in the plugin I think we're using:

https://github.com/phhu/videojs-abloop/issues/11

No traction on fixing it in the last 4 years. May need to fork it / find another plugin / submit a patch back to it.

BonerFide commented 2 weeks ago

One other thing to note, is long term I'd like to see this sort of be the way we make markers (or any sub-division of a movie / scene that doesn't require re-encoding), with an in/out option and sub-second precision. So it may be the sort of thing fixed in conjunction with that sort of added feature.