search

stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
9.26k stars 794 forks source link

[Bug Report] Naming issue for Taiwan in list of countries #5237

Open null-von-sushi opened 1 month ago

null-von-sushi commented 1 month ago

Describe the bug Taiwan is currently labelled a "province of China". This name is only used by communist China and countries/institutions that pander to them, and does not represent the people of Taiwan.

Officially the island is a province of the Republic of China, however the current phrasing makes it seems as if it was subservient to the People's Republic of China (the communist one). Similar situation like north and south korea going on, basically.

To Reproduce Steps to reproduce the behavior:

  1. Go to performers, and edit any performer.
  2. Click on 'Country'
  3. Scroll down to 'Taiwan'
  4. See issue.

Expected behavior The name should just be Taiwan (ideal and neutral) or Republic of China (Taiwan) (the official phrasing used by the government but not as neutral).

Screenshots image

Stash Version: (from Settings -> About): ` v0.26.2 Build hash: 2a373a25 Build time: 2024-06-27 00:28:19 `

Desktop (please complete the following information):

Additional context Set it up today, running via docker compose via CasaOS on my server.

WithoutPants commented 1 month ago

We get the country list from i18n-iso-countries, which in turn is from the ISO codes: https://www.iso.org/obp/ui/#iso:code:3166:TW

See also: https://github.com/michaelwittig/node-i18n-iso-countries/issues/266

I'm not overly inclined to make local code changes to override this behaviour in the stash code that implies a given political stance.

null-von-sushi commented 1 month ago

I understand that you don't want to make local changes, however somehow in the last few years there's more and more projects which have been hijacked to push China's propaganda. It's not about America or whatever, but simply the reality on the ground is that it's not what we call the country. But if course there's enough Chinese to pressure people into giving in, and once it's changed (like in #231), then people say they don't want to touch it because of politics.

Anyway, I understand you are not going to be changing it for this project, but I do have one question though if you don't mind @WithoutPants. According to that library's commit f1dee5e there should be an alternative name. How come this isn't shown? Would I have to modify something in stash app locally to get it to use that? Consider it's already part of the lib, there should be a way to get stash to show it, right?

WithoutPants commented 1 month ago

Having considered this further, I'll look into adding some functionality for users to be able to customise this on their local systems.

null-von-sushi commented 1 month ago

Thank you very much 🙏

stg-annon commented 1 month ago

3871 related