stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
9.39k stars 803 forks source link

[Bug Report] Set organised flag should not be set #5403

Open Joly0 opened 1 month ago

Joly0 commented 1 month ago

Describe the bug I have configured the identify task so the default is not to set the organised flag and have configured each source that set the organised flag. In my head i thought, if none of the sources applied, then the organised flag would not be set. But this is not the case, even though none of the sources matched a scene and the default is not to set the flag, it is still set.

To Reproduce Steps to reproduce the behavior:

  1. Go to Identify settings
  2. Configure default organised flag to false
  3. Configure source organised flag to true
  4. Identify un-identifiable scene
  5. See issue

Expected behavior If no source applied to the scene, the organised flag shouldnt be set

Screenshots If applicable, add screenshots to help explain your problem please ensure that your screenshots are SFW or at least appropriately censored.

Stash Version: (from Settings -> About):

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

WithoutPants commented 4 weeks ago

I am not able to reproduce this.

WithoutPants commented 3 weeks ago

Based on user feedback on Discord, the current theory is the source that had Organised set to true was the Auto Tag scraper, which will often match. We'd need to verify in the logs to ensure that the scene in question was not identified and the Organised flag was set to true. Thus far, I haven't been able to reproduce otherwise.

Joly0 commented 3 weeks ago

If you tell me what i can do and provide, i will try my best to do so to fix this issue

WithoutPants commented 3 weeks ago

If you tell me what i can do and provide, i will try my best to do so to fix this issue

Which scraper/data source are you setting the Set Organised flag to true on?